Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security checklist #2218

Closed
ignopeverell opened this issue Dec 23, 2018 · 3 comments
Closed

Security checklist #2218

ignopeverell opened this issue Dec 23, 2018 · 3 comments

Comments

@ignopeverell
Copy link
Contributor

Some feedback from the libsecp audit and our use in grin, all simple things we could add for a little more defense in depth:

  • Zeroing of sensitive data through Drop (password, mnemonic)
  • Check zeroing of private keys in libsecp
  • More randomized tests to check invalid range proofs don't validate
  • Same for aggsigs
@ghost
Copy link

ghost commented Dec 28, 2018

randomness sources if even necessary.
E.g. https://github.com/mimblewimble/rust-secp256k1-zkp/blob/master/src/aggsig.rs#L36
uses thread_rng which, AFAIK, is backed by EntropyRng instead of OsRng

@ignopeverell
Copy link
Contributor Author

Randomness was already checked, with rand 0.5+ it's fine.

@yeastplume
Copy link
Member

Closing, out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants