Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tx pool kernel counts to tui status page #3111

Merged
merged 2 commits into from Nov 14, 2019

Conversation

antiochp
Copy link
Member

We added tx pool size to the tui status page previously.
This PR adds the kernel count in addition to this.
This provides a rough approximation of how much tx aggregation is occurring by comparing pool size (in transactions) to the size in kernels.

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once CI pass)

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the alignment is a bit off. See screen cap:
Capture d’écran 2019-11-13 à 15 51 08

@antiochp
Copy link
Member Author

Good catch. Will fix.

@antiochp antiochp merged commit 8d2c43d into mimblewimble:master Nov 14, 2019
@antiochp antiochp deleted the kernel_count_pool_tui branch November 14, 2019 16:21
@antiochp antiochp added this to the 3.0.0 milestone Dec 11, 2019
@antiochp antiochp mentioned this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants