Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup path handling with AsRef<Path> #3284

Merged

Conversation

antiochp
Copy link
Member

Cleanup how we pass paths around for the txhashset backend files.

Copy link
Contributor

@jaspervdm jaspervdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍 assuming all tests pass

@antiochp
Copy link
Member Author

Build failed on CI with -


llvm v10.0.0 [Approved]
llvm package files install completed. Performing other installation steps.
Downloading llvm 64 bit
  from 'https://github.com/llvm/llvm-project/releases/download/llvmorg-10.0.0/LLVM-10.0.0-win64.exe'
ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://github.com/llvm/llvm-project/releases/download/llvmorg-10.0.0/LLVM-10.0.0-win64.exe'. Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (500) Internal Server Error." 
This package is likely not broken for licensed users - see https://chocolatey.org/docs/features-private-cdn.
The install of llvm was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\llvm\tools\chocolateyinstall.ps1'.
 See log for details.

Kicking it off again to see if it fails consistently.

@antiochp
Copy link
Member Author

Looks like a temporary glitch, llvm downloaded successfully this time.

@antiochp antiochp merged commit e49eeca into mimblewimble:master Mar 30, 2020
@antiochp antiochp deleted the cleanup_txhashset_path_handling branch March 30, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants