[DNM] Refactor "leaf_set" #3428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
yolo
branch
2 times, most recently
from
016bcbe
to
7bd0294
Compare
phyro
added
the
abandoned
|
Closed and marked as 'abandoned'. This does not mean the PR is unworthy. This means that merging it would require further work that nobody appears prepared to do at this time, or the original author has been unresponsive for a significant amount of time. Anyone who want to continue work on this functionality is free to re-open this at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge prior to 5.0.0 (regardless of branch naming).
We currently update the leaf_set file in realtime as blocks are accepted.
This is the only file that we write to disk during block processing that is not append-only.
This PR is an exploration into removing this dependency and keeping the leafset bitmap purely in memory.
This would be backed by the existing output_pos index from the db.
The index is handled transactionally during block processing.
The leaf_set represents the list of output pos that make up the current UTXO.
Things we still need the leaf_set file for -
If the MMR files are strictly append-only then we can potentially -