Refactor PMMR read methods into trait #3454
Conversation
|
Testing this locally now. |
What did you need here? |
| { | ||
| type Item = T::E; | ||
|
|
||
| fn get_hash(&self, pos: u64) -> Option<Hash> { |
There was a problem hiding this comment.
Actually - can get_hash() and get_data() (and similar) not also be moved to the trait if we had a backend() fn?
There was a problem hiding this comment.
Yes, but that does mean we give access to the backend outside of the module. It might give use the temptation to accidentally use the backend directly.
There was a problem hiding this comment.
Hm on further thought, we could maybe add the backend() function to a separate trait that isn't visible outside of the module..
There was a problem hiding this comment.
Turns out this is not really possible, as it would expose the private trait:
error[E0445]: restricted trait `core::pmmr::pmmr::PMMRBackend<B>` in public interface
So I'd rather keep it like it is, with some duplicate code.
|
PMMRandReadOnlyPMMRhave a few common functions that are essentially duplicate code. I also needed access to one of thePMMRfunctions on theReadOnlyPMMR. This PR pulls these functions out of the specific impls and puts them in a common trait.