Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace deprecated failure crate with thiserror #3633

Closed
wants to merge 5 commits into from

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Apr 10, 2021

Will write detailed review notes soon.

To do:

  • Consider how best to handle conversion from .context()

@GeneFerneau
Copy link
Contributor

Consider how best to handle conversion from .context()

Possibly use anyhow::Error, or did you mean something else?

@phyro phyro added the abandoned Abandoned due to either lack of review or contribution. Could get revisited later. label Jan 6, 2022
@yeastplume
Copy link
Member

Closed and marked as 'abandoned'. This does not mean the PR is unworthy. This means that merging it would require further work that nobody appears prepared to do at this time, or the original author has been unresponsive for a significant amount of time. Anyone who want to continue work on this functionality is free to re-open this at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Abandoned due to either lack of review or contribution. Could get revisited later.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants