Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core references in grin_store crate to grin_core #3771

Merged
merged 2 commits into from Oct 3, 2023

Conversation

yeastplume
Copy link
Member

Trying to merge a wallet PR (and ending up in a rabbit hole), the latest version of the thiserror crate is implicitly referencing rust's core library, while the grin_store crate was also using the identifier core to reference grin_core. This updates grin_store's grin_core import to be explicit and resolve the error.

We probably shouldn't have used the name core, (see rust-lang/cargo#7760), but I think we'll be fine since we're exporting the crate as grin_core.

Reason for change: see dtolnay/thiserror#255

Also updates Cargo.lock

@yeastplume yeastplume merged commit 5e2aa59 into mimblewimble:master Oct 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant