Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure to use latest, fix warnings #66

Merged
merged 5 commits into from Mar 25, 2020

Conversation

yeastplume
Copy link
Member

Further update to CI settings and fix for warnings:

  • Use ubuntu-latest, windows-latest and macos-latest images
  • Fix dyn warning
  • Modify all instances of mem::uninitialized() to mem::MaybeUninit::uninit().assume_init()

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to reintroduce the rustup install thing otherwise this won't be tested against beta and nigthly.

@quentinlesceller
Copy link
Member

quentinlesceller commented Mar 25, 2020

Since rustup is installed you need to add:

macOS and Linux:

rustup toolchain install $RUSTUP_TOOLCHAIN
rustup default $RUSTUP_TOOLCHAIN

and Windows:

rustup toolchain install %RUSTUP_TOOLCHAIN%
rustup default %RUSTUP_TOOLCHAIN%

@quentinlesceller
Copy link
Member

quentinlesceller commented Mar 25, 2020

It looks like Rustup is not included in Windows Server 2019 (https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md). You might want to try the above. Otherwise you need to add:

    - script: |
         curl -sSf -o rustup-init.exe https://win.rustup.rs
         rustup-init.exe -y --default-toolchain %RUSTUP_TOOLCHAIN%
       displayName: Install Rust

@yeastplume
Copy link
Member Author

@quentinlesceller
Copy link
Member

@yeastplume can you try this on Windows:

rustup-init.exe toolchain install  %RUSTUP_TOOLCHAIN%
rustup-init.exe default %RUSTUP_TOOLCHAIN%

and remove this line:

rustup-init.exe -y --default-toolchain %RUSTUP_TOOLCHAIN%

@quentinlesceller
Copy link
Member

Wondering if this is necessary to export again the Cargo path on Windows (echo "##vso[task.setvariable variable=PATH;]%PATH%;%USERPROFILE%\.cargo\bin"). Not sure which one Windows is using. Or simply try to display the toolchain before cargo to be sure.

@quentinlesceller
Copy link
Member

Found the reason rust-lang/rustup#2203

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving my own fix 👍

@yeastplume yeastplume merged commit caa4999 into mimblewimble:master Mar 25, 2020
suemto pushed a commit to mwcproject/rust-secp256k1-zkp that referenced this pull request Oct 28, 2020
* update azure to use latest, fix warnings

* add toolchain commands

* Fix Win CI

* Go back to previous command

* The Fix

Co-authored-by: Quentin Le Sceller <q.lesceller@gmail.com>
vekamo added a commit to mwcproject/rust-secp256k1-zkp that referenced this pull request Sep 9, 2023
* Update CI (mimblewimble#65)

* attempt to fix windows build

* remove all explicit rust installation steps

* update mac os image

* Implement PartialOrd and Ord (mimblewimble#62)

* Implement PartialOrd and Ord

* Fix spaces

* Add create commit from pubkey function (mimblewimble#64)

* Update azure to use latest, fix warnings (mimblewimble#66)

* update azure to use latest, fix warnings

* add toolchain commands

* Fix Win CI

* Go back to previous command

* The Fix

Co-authored-by: Quentin Le Sceller <q.lesceller@gmail.com>

* version bump for release (mimblewimble#67)

* fix from_pubkey function

* Revert "fix from_pubkey function"

This reverts commit a5f08e3.

* Update Grin Website

* Commit to pubkey fix (mimblewimble#68)

* commit_to_pubkey fix

* version bump for next release

* retrigger build

* Fix compiler warning (mimblewimble#70)

* Fuzz tests for various components

* Fix error formatting (mimblewimble#75)

* Update version to v0.7.10

* Update zeroize dependency (mimblewimble#78)

* Bump version to v0.7.11 (mimblewimble#79)

* update dependency seck256k1 branch to latest master with aggsig subtraction function

* Aggsig signature subtraction function, rust side (mimblewimble#81)

* addition of ffi+api functions for aggsig partial sig subtract

* updated aggsig lib function to return more results based on underlying function

* update submodule to latest master

* clean up test result check

* bump version number

* update depend/secp256k1-zkp

* update version

---------

Co-authored-by: Yeastplume <yeastplume@protonmail.com>
Co-authored-by: jaspervdm <j@sper.dev>
Co-authored-by: Quentin Le Sceller <q.lesceller@gmail.com>
Co-authored-by: Nym Seddon <unseddd@shh.xyz>
Co-authored-by: GeneFerneau <80422284+GeneFerneau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants