mime-types 1.17.2 fails tests with ruby 1.8.7

[graaff]

When I try to run the tests with ruby 1.8.7 I get the following failure:

  1) Failure:
test_platform_eh(TestMIME_Type) [./test/test_mime_type.rb:182]:
Failed refutation, no message given

33 tests, 139 assertions, 1 failures, 0 errors, 0 skips

[halostatue]

I can't reproduce on the Mac with 1.8.7-p358.

/Users/AZiegler/.rbenv/versions/1.8.7-p358/bin/ruby -w -Ilib:bin:test:. -e 'require "rubygems"; gem "minitest"; require "minitest/autorun"; require "test/test_mime_type.rb"; require "test/test_mime_types.rb"' -- 
Run options: --seed 54862

# Running tests:

.................................

Finished tests in 0.007822s, 4218.8699 tests/s, 18026.0803 assertions/s.

33 tests, 141 assertions, 0 failures, 0 errors, 0 skips

This is what will be going out tonight as 1.18.

[graaff]

I have the same problem with the released 1.18 version. This is on Gentoo Linux using ruby 1.8.7 (2011-12-28 patchlevel 357) [x86_64-linux].

yaml = #<MIME::Type:0x7f3b05308ff8 @sub_type="yaml", @docs=nil, @content_type="text/x-yaml", @obsolete=nil, @url=nil, @registered=true, @encoding="8bit", @media_type="text", @raw_sub_type="x-yaml", @simplified="text/yaml", @System=/linux/, @extensions=["yaml", "yml"], @raw_media_type="text">

Please let me know if you need more info on this, I'd be happy to dig around a bit more if you tell me what you need.

[halostatue]

I think I see the problem.

Can you try changing line 9 of test/test_mime_type.rb to:

    MIME::Type.from_array('text/x-yaml', %w(yaml yml), '8bit', 'xunil')

You'll get two different failures, but you get those, I know how to fix it and will commit a patch later.

[graaff]

  1) Failure:
test_to_a(TestMIME_Type) [./test/test_mime_type.rb:267]:
--- expected
+++ actual
@@ -1 +1 @@
-["text/x-yaml", ["yaml", "yml"], "8bit", /xunil/, nil, nil, nil, false]
+["text/x-yaml", ["yaml", "yml"], "8bit", /linux/, nil, nil, nil, false]


  2) Failure:
test_system_equals(TestMIME_Type) [./test/test_mime_type.rb:251]:
Expected: /xunil/
  Actual: /linux/

  3) Failure:
test_to_hash(TestMIME_Type) [./test/test_mime_type.rb:273]:
--- expected
+++ actual
@@ -1 +1 @@
-{"Extensions"=>["yaml", "yml"], "Content-Transfer-Encoding"=>"8bit", "Registered"=>false, "System"=>/xunil/, "Content-Type"=>"text/x-yaml", "URL"=>nil, "Docs"=>nil, "Obsolete"=>nil}
+{"Extensions"=>["yaml", "yml"], "Content-Transfer-Encoding"=>"8bit", "Registered"=>false, "System"=>/linux/, "Content-Type"=>"text/x-yaml", "URL"=>nil, "Docs"=>nil, "Obsolete"=>nil}

[graaff]

Fix confirmed, I just tested with the new commit and tests now pass on ruby 1.8, ruby 1.9 and jruby. Thanks!