Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimemagic/overlay is not available in 0.4.3 release #140

Open
mejackreed opened this issue Mar 26, 2021 · 10 comments
Open

mimemagic/overlay is not available in 0.4.3 release #140

mejackreed opened this issue Mar 26, 2021 · 10 comments

Comments

@mejackreed
Copy link

While added in dec6d5e

I'm not seeing this available in the tag 0.4.3 on GitHub or in the released version on RubyGems. This is causing some upstream dependency issues. Can this make it into a release? Thanks!

@mvz
Copy link

mvz commented Mar 26, 2021

I think it's only supposed to be part of the 0.3.x series.

@key88sf
Copy link

key88sf commented Mar 26, 2021

Same issue here -- upstream builds failing for us due to this.

Mar 26, 05:08:54 PM  Fetching gem metadata from https://rubygems.org/........
Mar 26, 05:08:54 PM  Your bundle is locked to mimemagic (0.3.5), but that version could not be found
Mar 26, 05:08:54 PM  in any of the sources listed in your Gemfile. If you haven't changed sources,
Mar 26, 05:08:54 PM  that means the author of mimemagic (0.3.5) has removed it. You'll need to update
Mar 26, 05:08:54 PM  your bundle to a version other than mimemagic (0.3.5) that hasn't been removed
Mar 26, 05:08:54 PM  in order to install.```

@mejackreed
Copy link
Author

Thanks @mvz , I didn’t keep up with that change. We will pin to the 0.3.x series

@key88sf
Copy link

key88sf commented Mar 26, 2021

@mejackreed @mvz Will this be resolved on your end, or we need to modify something on our end?

@pjmartorell
Copy link

Version 0.4.3 is published in Rubygems but mimemagic/overlay was removed in 0.4.1. This is what the changelog states: 78b9da8#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR7-R10

@mejackreed
Copy link
Author

mejackreed commented Mar 26, 2021

It would be nice to leave the file in the 0.4.x series as other gems would need to then start pinning to the 0.3.x series if possible. carrierwave and paperclip are examples of two popular gems that require 'mimetype/overlay' that likely break under these conditions.

Especially if it was (or was intended to be in) in an earlier 0.4.1 release as @pjmartorell points out.

Thanks for all of the work you have had to do this week.

@mvz
Copy link

mvz commented Mar 27, 2021

Pinning a pre-1.0 dependency to a minor version is a good idea in general, IMHO. So carrierwave and paperclip should do that anyway.

@pjmartorell
Copy link

pjmartorell commented Mar 27, 2021

FYI carrierwave master no longer depends on mimemagic. paperclip is going to work anyway because it accepts any 0.3.x version of mimemagic and mimemagic 0.3.9 and 0.3.10 include mimagic/overlay again, so it's not going to crash.

In conclusion, @mejackreed you can use 0.3.10 if you want to keep using mimemagic/overlay

@pjmartorell
Copy link

pjmartorell commented Mar 28, 2021

There is an issue with carrierwave 2.2.0 because it's defining the mimemagic semantic version as >= 0.3.0 which accepts mimemagic 0.4.3 as a valid version, but this version makes carrierwave to crash. To circumvent this issue, I recommend to add mimemagic as a dependency in your Gemfille but with a version ~> 0.3.10. This will force the version 0.3.10 to be installed instead of 0.4.3.

@kalashnikovisme
Copy link

Just updated carrierwave to the last 2.2.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants