New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable_dimensions methods #589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 79% 79.16% +0.16%
==========================================
Files 39 39
Lines 2720 2722 +2
==========================================
+ Hits 2149 2155 +6
+ Misses 571 567 -4
Continue to review full report at Codecov.
|
@ckingdon95 I've addressed the requested changes thank you! |
src/core/types/time.jl
Outdated
@@ -31,6 +38,12 @@ struct TimestepValue{T} | |||
end | |||
end | |||
|
|||
""" | |||
TimestepValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't catch this till I saw you correct it on the other PR, but this one should be TimestepIndex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckingdon95 thanks just fixed this, so you're right this encompasses both PRs ... I'll close the docstrings one and wait for tests to pass on this one. If it looks good now you can approve and we'll be good to go sorry for confusion!
@jrising