Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable_dimensions methods #589

Merged
merged 5 commits into from Nov 20, 2019

Conversation

@lrennels
Copy link
Collaborator

lrennels commented Nov 15, 2019

lrennels added 2 commits Nov 15, 2019
@lrennels lrennels requested review from rjplevin and ckingdon95 Nov 15, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #589 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage      79%   79.16%   +0.16%     
==========================================
  Files          39       39              
  Lines        2720     2722       +2     
==========================================
+ Hits         2149     2155       +6     
+ Misses        571      567       -4
Impacted Files Coverage Δ
src/core/types/time.jl 100% <ø> (ø) ⬆️
src/core/model.jl 81.81% <ø> (ø) ⬆️
src/core/defs.jl 80.06% <100%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d7807...3f18276. Read the comment docs.

src/core/defs.jl Outdated Show resolved Hide resolved
src/core/defs.jl Outdated Show resolved Hide resolved
@lrennels

This comment has been minimized.

Copy link
Collaborator Author

lrennels commented Nov 20, 2019

@ckingdon95 I've addressed the requested changes thank you!

@@ -31,6 +38,12 @@ struct TimestepValue{T}
end
end

"""
TimestepValue

This comment has been minimized.

Copy link
@ckingdon95

ckingdon95 Nov 20, 2019

Collaborator

Sorry didn't catch this till I saw you correct it on the other PR, but this one should be TimestepIndex

This comment has been minimized.

Copy link
@lrennels

lrennels Nov 20, 2019

Author Collaborator

@ckingdon95 thanks just fixed this, so you're right this encompasses both PRs ... I'll close the docstrings one and wait for tests to pass on this one. If it looks good now you can approve and we'll be good to go sorry for confusion!

@lrennels lrennels requested a review from ckingdon95 Nov 20, 2019
@lrennels lrennels merged commit 65206bc into master Nov 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lrennels lrennels deleted the variabledimensions branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.