Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Django 1.11 work again #356

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Make Django 1.11 work again #356

merged 1 commit into from
Jun 7, 2017

Conversation

mimischi
Copy link
Owner

@mimischi mimischi commented Jun 7, 2017

The package django-bootstrap3-datetimepicker-2 does not work with Django 1.11. Currently there are two unmerged PRs (PR #65 and PR #66) that fix the problem. Randomly decided to go with PR #66 and specified it in our base.txt.

Meanwhile also updated Django to version 1.11.2.

@mimischi mimischi merged commit 74f22c9 into develop Jun 7, 2017
@mimischi mimischi deleted the compatible_django111 branch June 7, 2017 14:20
@codecov-io
Copy link

Codecov Report

Merging #356 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #356   +/-   ##
========================================
  Coverage    60.25%   60.25%           
========================================
  Files           50       50           
  Lines         1600     1600           
========================================
  Hits           964      964           
  Misses         636      636

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e187f0f...bbb0db4. Read the comment docs.

@eborche2
Copy link

I've been using the fix from PR #65 in my project on Django 1.11. Since you made a post that the issue was resolved, I tried this package without the fix and it still does not work. Could you please merge in PR #65 so that the package is compatible with Django versions after 1.9. Thank you.

@mimischi
Copy link
Owner Author

@eborche2 I'm slightly confused. Did you mean to comment in the django-bootstrap3-datetimepicker repository? Surprisingly enough we have an issue #65 which references the datetimepicker, while you're probably referencing the PR 65 in that other repository?

@eborche2
Copy link

I apologize, you are correct. I followed the link from PR #65 in django-bootstrap3-datetimepicker and didn't realize it was a link to a different repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants