Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer setup and add a test #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MatthewCaseres
Copy link

@MatthewCaseres MatthewCaseres commented Dec 4, 2022

Curious what you think about this -

  • adds poetry which should help with publishing/managing environment. This is done by using a "Python devcontainer", and then installing poetry with a "postCreateCommand"
  • adds pytest, I did a single test but this should be expanded.
  • adds CI/CD

You should be able to open in codespaces and then once the postCreate.sh script runs, run pytest when poetry shell is active. The container also includes https://github.com/nektos/act so you can locally test GitHub workflows quickly and without committing changes.

@MatthewCaseres
Copy link
Author

  • not super sure which python versions should be supported. I just test on I think 3.9 but we can test on all versions that should be supported.
    • removed dependency for "six" which seems like a python2 back compatibility thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant