Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide meaningful default shared folders #501

Closed
jmuheim opened this issue Jan 5, 2017 · 2 comments
Closed

Provide meaningful default shared folders #501

jmuheim opened this issue Jan 5, 2017 · 2 comments

Comments

@jmuheim
Copy link

jmuheim commented Jan 5, 2017

I'm unsure which folders I should share. At the time being, it's the following:

set :shared_dirs, fetch(:shared_dirs, []).push('log', 'tmp', 'public/uploads')

Maybe you should provide meaningful default shared folders? Instead of

# set :shared_dirs, fetch(:shared_dirs, []).push('somedir')

something like

# set :shared_dirs, fetch(:shared_dirs, []).push('log', 'tmp', 'public/uploads')

because for shared files you already do provide meaningful default ones:

# set :shared_files, fetch(:shared_files, []).push('config/database.yml', 'config/secrets.yml')
@arun057
Copy link

arun057 commented Apr 10, 2017

should probably include public/assets and vendor/bundle as well

@d4be4st
Copy link
Member

d4be4st commented Sep 8, 2017

@arun057 they are included by default

Will add to documentation

@d4be4st d4be4st closed this as completed in f4a09c3 Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants