Save window excursion when previewing #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When consult is used with selectrum and mini-frame (minibuffer in a child-frame), window changes due to previews are not reverted on abort (`C-g`). Saving the window excursion while selecting a candidate appears to fix the issue and doesn't appear to introduce any other issues.
|
This is not the correct fix since it is too intrusive. Can you please describe the issue precisely? Which kind of window changes are introduced during preview? |
|
Please create a separate issue. In case you are interested in investigating this, take a look at the consult--preview-position function which saves and restores the marker. Window configuration is not saved there as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consult is used with selectrum and mini-frame (minibuffer in a child-frame), window changes due to previews are not reverted on abort (
C-g).Saving the window excursion while selecting a candidate appears to fix the issue and doesn't appear to introduce any other issues. However, I'm not 100% sure why this is an issue with mini-frame, and not an issue without it, so I have no idea if this is the correct fix.