Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve consult line experience #20

Closed
wants to merge 3 commits into from
Closed

improve consult line experience #20

wants to merge 3 commits into from

Conversation

s-kostyaev
Copy link

Add optional arg initial to consult line. Implement consult-line-symbol-at-point & consult-line-from-isearch. See #16

minad
minad reviewed Dec 1, 2020
View reviewed changes
Copy link
Owner

@minad minad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nitpicks. And please document the commands in the readme too. Looks good besides that!

consult.el Outdated Show resolved Hide resolved
consult.el Outdated Show resolved Hide resolved
minad
minad reviewed Dec 1, 2020
View reviewed changes
consult.el Outdated Show resolved Hide resolved
@s-kostyaev
Copy link
Author

@minad Thanks for review. Some fixes provided.

@minad
Copy link
Owner

minad commented Dec 1, 2020

Merged after squashing. Thank you.

@minad minad closed this Dec 1, 2020
@s-kostyaev s-kostyaev deleted the improve-consult-line branch December 2, 2020 16:08
@minad minad mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minad minad minad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-kostyaev @minad