Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIT_DIR isn't unset in repo.method_missing #5

Closed
bronson opened this issue Aug 25, 2010 · 1 comment
Closed

GIT_DIR isn't unset in repo.method_missing #5

bronson opened this issue Aug 25, 2010 · 1 comment

Comments

@bronson
Copy link
Contributor

bronson commented Aug 25, 2010

 def method_missing(name, *args, &block)
    cmd = name.to_s
    if cmd[0..3] == 'git_'
      ENV['GIT_DIR'] = path
      ... etc

The problem is, GIT_DIR remains set even after method_missing returns! This will cause trouble for any code that later shells out to git. For instance, my Ruby script might shell out to the Repo python script, then fail when Repo fork and execs a git process.

@minad
Copy link
Owner

minad commented Aug 25, 2010

fixed by 2e882f4

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants