Camel Case with single quotes doesnt work as expected

[bobrowadam]

Hi,
When working in a typescript-mode buffer, jinx doesn't identify camel case strings wrapped with single quotes. double quoting works fine.
'camelCase' => marked as incorrect
"camelCase" => correct

I tried to debug and I think that the problem is in this line:

jinx/jinx.el

Line 465 in 09969c5

(when (looking-at "\\([[:upper:]]?[[:lower:]]+\\)\\(?:[[:upper:]][[:lower:]]+\\)+\\>")

The regex "\([[:upper:]]?[[:lower:]]+\)\(?:[[:upper:]][[:lower:]]+\)+\>" doesn't match when the word wrapped with single quotes.

Thanks

[minad]

I can reproduce this problem. I think the problem is that Jinx has special handling for apostrophes at the beginning or end of words. See this code right before the regexp, you've mentioned:

jinx/jinx.el

Lines 452 to 460 in 09969c5

	;; No quote or apostrophe at start or end
	(while (and (< word-start word-end)
	(let ((c (char-after word-start)))
	(or (= c ?') (= c ?’))))
	(cl-incf word-start))
	(while (and (< word-start word-end)
	(let ((c (char-before word-end)))
	(or (= c ?') (= c ?’))))
	(cl-decf word-end))

I am happy to take a patch, if we figure out a way to handle this edge case. Otherwise I consider this a low priority issue, given that I hope to preserve the existing apostrophe handling.

EDIT: I gave it a try and the problem is exactly as you described. It is simple: The regexp doesn't match since the single quote is treated as part of words (apostrophe). I am afraid we cannot easily fix this by default. However it should be possible to reconfigure the single quote as non-word character in the jinx--syntax-table, if you accept the downside that quotes are then not considered parts of words anymore, which may lead to false positives.

[bobrowadam]

Thanks for the reply!
As you mentioned, I'll try to configure the syntax-table and see how bad the experience is with word apostrophes.
If I come out with a fix I'll be happy to send a PR.