Updated moped to 2.0, added compatibility for ruby_bson v1 and v2+ #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minad
added a commit
that referenced
this pull request
Aug 11, 2014
Updated moped to 2.0, added compatibility for ruby_bson v1 and v2+
|
Ok, I merge it for now. Before the next release, the test suite has to be made green again. Would be cool if you can help with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, updated moped to latest version.
Added compatibility for both
ruby_bsonv1 (currently used bymongo) and v2 (currently used bymoped). Also made sure that if mongo updated to v2 in the future, things keep working like they should.I've run the rspec tests for both official and moped. Moped succeeds with 0 failures. Official remains the same with 4 failures before and after my patch (mostly concurrency issues).