-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No table styling in example blocks? #33
Comments
You can quote Org syntax with comma in example blocks, see https://irreal.org/blog/?p=5503. For some reason this is required by Org for headline stars. But it seems that tables are indeed not highlighted in example blocks. Overall the treatment of Org syntax in these example blocks seems inconsistent.
org-modern could do a bit better here. But I don't know how org-mode manages the distinction in the Org font locking setup. I'd appreciate some insight here. The same issue affects org-modern styling of lists and of other syntax elements. EDIT: It seems that the function |
Thanks! |
Good day, Daniel. I wonder if a better solution to the problem in this general area is to add org-modern's font-lock-keywords to the variable I use this hook in my personal configuration to fontify horizontal rules and this rule is not applied in an example block:
Maybe you considered this but decided against it? Anyway, I thought this would be worth mentioning. You can see a screenshot here: http://0x0.st/oSS0.png |
@Vizs Could be that this would work better. I am not that much into the org code base, so I don't recall if I considered this or not. You can probably answer this better than me. Did you test moving all (or most) org-modern--font-lock-keywords to org-font-lock-extra-keywords? If this works well we could change the approach. In that case, feel free to create a PR. |
Sure, I will do some tests on my side and see where it leads us to. |
There is also |
That's what I'm doing. But now, I'm unsure how to remove the org-modern keywords when you disable the mode 🙃 |
Ah lol yes, I didn't read your snippet. |
That hook is called before org-mode-hook is run so doing this way would make org-modern a global minor mode instead (IIUC). But I made a new hook that was basically |
Hi,
As far as I understand, literal example blocks in org-mode (
#+begin_example
) are meant for text that does not receive any markup. However, org-modern renders a "column" of pipes likeas if it was part of a table (i.e. with a solid vertical line), even in literal example blocks. Is this the intended behavior?
Thanks for the great package(s)!
The text was updated successfully, but these errors were encountered: