Osmium input reader #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object files and libraries should be specified before the output file to prevent build problems on certain machines (e.g. my machine)
These tools are not kept up-to-date and can be downloaded from their individual websites instead. They are not used inside mapgen.sh either.
…lementation This enables us to read also PBF files
|
I don't have time to verify the output currently. The possibility to read pbf is definitely a huge advantage. I will take a look at this in a while. |
Parsing the 14 GB planet.osm.pbf fails without these flags.
|
I compared the results of parsing the north-rhine-westfalia.osm extract with either bz2 and pbf and they looked absolutely identical when viewed with qgis. I added another small addition to the makefile to make sure that the bigger planet.osm.pbf files (> 14 GB) can be read too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
I modified the code to use the Osmium framework for reading the OSM data. This enables us to use the PBF files which are more space-efficient and also faster to read. It would be great if you could verify that the code still produces the same data, I'm not quite sure how to do it myself.
Turbo