-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish extensions on ELPA #83
Comments
Let me keep the focus here instead of over at the First of all, I agree with you: let's keep Vertico as small as possible. It'll be impossible to please everyone with a single package and on the long run you risk adding hacks over hacks to make everyone happy. Not feasible, IMHO. As for the package name, I like |
One technical issue with the extensions is that some of them are mutually exclusive, for example the display extensions (flat, buffer, reverse). You can install them of course at the same time, but you can only activate one of them at once. The extensions require more thought from the side of the user, while Vertico is easy to use. Another option to consider - do not package up the extensions at all, but this is probably too inconvenient. A |
True, but the documentation can highlight this mutual exclusion and make the user decide what suits their needs. I mean, Vertico is already working fine out of the box, so you can expect the user to read the documentation before running wild on all the extensions at the same time. |
Sure, what I mean is that it is justified to have these as extensions then, packaged up separately or not at all, since they have a slightly different level of "robustness", "ease of use" etc. The main Vertico is a starting point and then users can go from there. I mean this is one of the main ideas of the whole Consult/Embark/Orderless/Vertico ecosystem, that you can adopt these things step by step. |
You can also add checks that sent a warning/error to |
Yes, of course I could. But probably I won't do this. This is the responsibility of the user. I can document it though that some extensions are incompatible with each other, if that isn't kind of obvious. But even if you turn on multiple incompatible extensions there won't be errors, you just don't see the desired effect if you enable for example vertico-flat and vertico-buffer at the same time. On the other hand, where it is easily possible to make extensions compatible, I do that. For example vertico-flat is compatible with vertico-quick/vertico-indexed. |
Is it possible that you could make separate package recipes for each of them that target the individual extension files? It seems like that's possible on MELPA, not sure about ELPA. |
Of course I could package them up all separately (both on ELPA or MELPA). But this is an unnecessary maintenance burden I would like to avoid. Furthermore it is too limiting when extensions are removed, replaced etc, since you are committed to the packages. I would like to have the possibility for more experimentation. |
Naming discussion:
vertex :)
|
Haha @jaor, this is just too good. I have to grab this name ;) EDIT: The problem is that the naming convention won't be clear. There must be a vertex.el file and then the other files will be called vertico-*.el, which is not consistent. I could also call them vertex-*.el, but I don't want to introduce different names, e.g., |
Not a vertico user (yet) but I think packaging these up together is fine. A single top-level readme with specifics about what each does and which don't work together is I think completely sufficient. Vertico-extensions is a fine name. Vertico-experimental is another option if you want to stress the aspect that the user is required to do a little more with these. To follow the dired example you could name it vertico-x. |
I say keep the extensions here, as is, but add a README to that directory? Maybe can reconsider later? |
hello, I have found that extensions directory is ignored, so do you mean user should download and install el files by hand? |
The fact that the extensions do not show up when installing Vertico from ELPA was the main reason I raised this question to @minad in the first place. :) |
Yes, agreed. The example in the vertigo config README further confuses this, because it suggests you can load an extension like But obviously this doesn't work out of the box. |
Yes, that example is slightly confusing. With With
|
For now I moved the vertico-directory configuration example to the extensions section to reduce the confusion, see https://github.com/minad/vertico/#extensions. |
IMO,
There are a large number of possible extensions for a completion system. Therefore if you would like to separate them from |
Please add extensions to at least Melpa. I don't want to use straight and this is not working for me either
|
Try just |
@jdtsmith The same result |
Sorry I found the reason.
I moved repo to cache and everything works fine |
I'm not using any of the extensions, and I wouldn't be bothered in the slightest to have those files sitting in my hard drive... What's the advantage of a separate package? |
(when unusualCodeStructure
(moreWorkFor [ nixUsers guixUsers ])
(when codeIsTooGoodToBitrot
(inevitableDuplicateWorkFor everyone))) |
vertico extensions aren't available yet See minad/vertico#83
The sentiment here seems to be that the extensions should be distributed together with the package. I am not opposed to that - as far as I can tell the extensions are mostly stable enough. Originally the extensions were thought as a staging area. In any case I don't want to move extensions functionality to the main library. |
vertico extensions aren't available yet See minad/vertico#83
Let this settle first a bit. The extensions are still new. The packages can be installed by hand via
package-install-file
for now and are in any case more interesting for experienced folks, who want to tweak Vertico more heavily.Naming discussion:
Alternatively make the extensions part of the Vertico package. But I intend to keep the package itself small and focused. The extensions are there, since there does not exist the one solution which fits everyone, e.g., in particular users may like to adjust the display code (vertico-buffer, vertico-reverse, vertico-flat).
cc @manuel-uberti, see also discussion in minad/uchronia@f677368
The text was updated successfully, but these errors were encountered: