Fix lint errors

Follow up #40

cmd/attribute.go

@@ -17,8 +17,8 @@ func newAttributeCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "attribute",
 		Short: "Edit attribute",
-		Run: func(cmd *cobra.Command, args []string) {
-			cmd.Help() // nolint: errcheck
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return cmd.Help()
 		},
 	}
 
@@ -147,7 +147,7 @@ Arguments:
 
 	flags := cmd.Flags()
 	flags.Bool("newline", false, "Append a new line before a new attribute")
-	viper.BindPFlag("attribute.append.newline", flags.Lookup("newline")) // nolint: errcheck
+	_ = viper.BindPFlag("attribute.append.newline", flags.Lookup("newline"))
 
 	return cmd
 }

cmd/block.go

@@ -17,8 +17,8 @@ func newBlockCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "block",
 		Short: "Edit block",
-		Run: func(cmd *cobra.Command, args []string) {
-			cmd.Help() // nolint: errcheck
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return cmd.Help()
 		},
 	}
 
@@ -163,7 +163,7 @@ Arguments:
 
 	flags := cmd.Flags()
 	flags.Bool("newline", false, "Append a new line before a new child block")
-	viper.BindPFlag("block.append.newline", flags.Lookup("newline")) // nolint: errcheck
+	_ = viper.BindPFlag("block.append.newline", flags.Lookup("newline"))
 
 	return cmd
 }

cmd/body.go

@@ -16,8 +16,8 @@ func newBodyCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "body",
 		Short: "Edit body",
-		Run: func(cmd *cobra.Command, args []string) {
-			cmd.Help() // nolint: errcheck
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return cmd.Help()
 		},
 	}
 

cmd/root.go

@@ -21,8 +21,8 @@ func init() {
 	flags := RootCmd.PersistentFlags()
 	flags.StringP("file", "f", "-", "A path of input file")
 	flags.BoolP("update", "u", false, "Update files in-place")
-	viper.BindPFlag("file", flags.Lookup("file"))     // nolint: errcheck
-	viper.BindPFlag("update", flags.Lookup("update")) // nolint: errcheck
+	_ = viper.BindPFlag("file", flags.Lookup("file"))
+	_ = viper.BindPFlag("update", flags.Lookup("update"))
 
 	setDefaultStream(RootCmd)
 }

editor/filter_vertical_formatter.go

@@ -50,7 +50,7 @@ func trimLeadingNewLine(tokens hclwrite.Tokens) hclwrite.Tokens {
 		}
 	}
 
-	return tokens[begin:len(tokens)] // nolint: gosimple
+	return tokens[begin:]
 }
 
 // removeDuplicatedNewLine removes duplicated newlines

editor/test_helper.go

@@ -17,8 +17,7 @@ func setupTestFile(t *testing.T, contents string) string {
 	path := f.Name()
 	t.Cleanup(func() { os.Remove(path) })
 
-	// nolint: gosec
-	if err := os.WriteFile(path, []byte(contents), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(contents), 0600); err != nil {
 		t.Fatalf("failed to write test file: %s", err)
 	}
 

main_test.go

@@ -90,7 +90,11 @@ func TestHCLEditMain(t *testing.T) {
 			// So that the second run is able to run main() and this first run can verify the exit status returned by that.
 			//
 			// This technique originates from https://talks.golang.org/2014/testing.slide#23.
-			cmd := exec.Command(os.Args[0], "-test.run=TestHCLEditMain") // nolint: gosec
+			self, err := os.Executable()
+			if err != nil {
+				t.Fatal(err)
+			}
+			cmd := exec.Command(self, "-test.run=TestHCLEditMain")
 			cmd.Env = append(
 				cmd.Env,
 				os.Environ()...,
@@ -112,7 +116,7 @@ func TestHCLEditMain(t *testing.T) {
 			cmd.Stdout = stdout
 			cmd.Stderr = stderr
 
-			err := cmd.Run()
+			err = cmd.Run()
 
 			if got := stdout.String(); got != tc.wantStdout {
 				t.Errorf("Unexpected stdout: want %q, got %q", tc.wantStdout, got)