Use newest plugin when multiple versions are found #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to always use newest plugin version when multiple versions found.
background
If you have multiple plugin versions as follows:
$ ls -1 ~/.terraform.d/plugins/ terraform-provider-foobar_v1.0.0_x4 terraform-provider-foobar_v1.1.0_x4
tfschema uses foobar's
v1.0.0
orv1.1.0
randomly.The cause is in the following part.
tfschema/tfschema/client.go
Lines 66 to 72 in 0980d8e
discovery.FindPlugins
returnsdiscovery.PluginMetaSet
.It is defined as
map[PluginMeta]struct{}
.https://github.com/hashicorp/terraform/blob/v0.11.7/plugin/discovery/meta_set.go#L7
So its iteration order is not guaranteed.