1Password isn't working with Min #1981
Labels
Comments
|
I was able to get this error message by "inspecting browser": |
|
This is not similar to #1626, because in my case I cannot authenticate as shown in the first screenshot. Whenever I type my email, password and secret key, they're prompt back again to me. |
|
What happens if you open the terminal and run |
I get: However, if I try with the following command: That seems to work. |
|
Did you have the 1password CLI previously set up before using it in Min? What version do you have installed ( |
|
No, I didn't have it installed before. I tried reinstalling it, but end up having the same issue.
|
|
Ok thanks. It looks like the issue is that the 1password integration in Min is set up to work with an old version of the CLI (0.10), and the command syntax has changed in the latest versions (currently 2.1.0). So we need to update our integration to match. The old version is still available: https://cache.agilebits.com/dist/1P/op/pkg/v0.10.0/op_darwin_amd64_v0.10.0.pkg (and is what you should get if you click the download link in the install popup in Min). However, I don't think that version will run on ARM, so it may not work for you unless you can configure it to run with Rosetta. |
|
Thanks for your update @PalmerAL. Downloading the file you mentioned worked for me (had to uninstall the version 2.1 I had). I'll be keeping an eye here for the update to support the new version :) |
|
I am on Arch so I don't know what to do with a pkg file. As for the newer op cli, min doesn't have a section to enter in the user's 1P site and does it handle the 2FA OTP code? Using OP app command is "op signin [vault url] [email] [secret key]" then entering 2FA OTP code to get a session token. |
|
@lpossamai Can you try PR #1990 if you have a chance? (Instructions to run: https://github.com/minbrowser/min#developing). The first time you launch it, it should walk you through upgrading to 1Password CLI v2, and then autofill should work with the new CLI. |
|
@hakarune You'll need to install the CLI from outside Min; I think this is what you want: https://aur.archlinux.org/packages/1password-cli (but it's v2, so you'll need the PR I mentioned above for this to work also). 2FA isn't supported at the moment. |
Oh okay. So even if I downgraded to v1 and then upgraded to v2 it won't work with 2FA? I understand. I'll continue to use the cli and gui app until 2FA is supported within min. Thank you for the quick response. |
Hi @PalmerAL , thanks for that. Just so I know I'm in the right track, do I need to install Node, then install its dependencies Thanks! |
Install node, and then: |
Yes, I was in the right track.. but am getting the error below when running |
|
That's weird - it's trying to install a really old version of Electron, but we specify a newer version in the package.json: https://github.com/minbrowser/min/blob/master/package.json#L50 Also, it's complaining about the ecstatic package, but that doesn't appear anywhere in our dependency tree AFAICT (even indirectly). Are you in the right directory ( |
|
Hmm.. Yes, I am in the right directory I'll keep troubleshooting! |
I'm sorry @PalmerAL , but I can't get it working. Tried:
I don't know what else I can try, but looks like this is an issue on my end. |
|
Hm, I don't know. I'll post a beta release sometime soon that you can try though. |
|
Any updates here, please? Sorry, kinda tired of having CTRL+C/CTRL+V my passwords lol |
|
Sorry for the lack of communication here. I just posted a beta release that should fix this: https://github.com/minbrowser/min/releases/tag/v1.25.0-beta , please let me know if it works for you. |
|
Thanks, @PalmerAL . I've tried it but I still face the same issue, where Min asks for the 1password username and password over and over. Tried with You can see the video of the issue here: https://youtu.be/uG-LZoorKls Min version: Any suggestions? |
|
I think I've found the issue (78733fb), can you try this build: https://workdrive.zohoexternal.com/file/m5t3g2457de2f03e84478953c6e145dd9b667 ? |
Thanks! It's working... it's not asking for the password anymore. However, no password comes up. If I use Tried |
|
Can you explain more what happens when you use the shortcut (maybe with a screenshot)? If you're seeing a list of usernames, you should be able to click on one of those to fill in the password. Also, what websites is this happening on? |
Check out the screenshot here: https://tmpfiles.org/dl/319637/screenrecording2022-06-17at10.08.35am.mov You can see that even by using |
|
OK, thanks for the video, can you try this one? https://workdrive.zohoexternal.com/file/7miztb4425b0cb27b4b43a4c93852166c111a |
I've tried that one and it happens the same issue as described here: #1981 (comment) You can check the screen recording here: https://tmpfiles.org/dl/319665/screenrecording2022-06-17at11.28.05am.mov More logs: |
|
I think I was too late to download the recording before it expired, which is unfortunate. The logs don't make much sense to me; the primary error seems to be:
which should only happen if you exited the signin dialog without entering a password or key, but I'm assuming you did. Can you try starting over with a fresh install of the CLI?
|
|
Hi! I've removed Min will ask me to setup 1Password. Followed the steps but the 1password login page keeps showing up. It doesn't accept my login details. Video: https://tmpfiles.org/dl/320627/screenrecording2022-06-18at9.08.36am.mov I'm using Min |
|
OK. I've made another build with more logging that should hopefully help: https://workdrive.zohoexternal.com/file/gy4tc502d50cc1c5b47f4b5e774907b7f55d0 Can you do this?
|
|
I've done what you requested. Here are the logs: Thanks! |
|
Oh, OK. The issue is this setting in 1password:
I think supporting biometric unlock will be fairly difficult. From the docs about it here it seems designed to only work from within an interactive terminal session; I tried testing this quickly, and it seems to silently fail when run within a node subprocess. Also, for some reason, enabling biometric unlock disables assigning shorthand names to accounts, which we use to distinguish between the account signed in to Min autofill and other accounts registered in the CLI, which could be different. (This is apparently by design: "within biometric unlock, there is no such concept as an account shorthand"). If you're OK with turning off that setting, you should be able to do that and then sign in through Min using your password. If you want/need to leave biometric unlock enabled for the CLI, I'm afraid I don't see a clear solution at the moment :( |
|
Thanks for your reply and help @PalmerAL . Yes, disabling biometric unlock works. However, every 5 minutes or so Min will ask me to re-enter the 1Password password, which is really annoying since the password has more than 40 characters :D But safe to close this issue. Thanks again. |
|
Hm, is it actually every 5 minutes? It's supposed to be "30 minutes of inactivity" (https://developer.1password.com/docs/cli/v1/reference#how-signin-works). The definition of "inactivity" is also interesting. Right now, that's just the 1password CLI tracking the time since the last password request, so 30 minutes past when you last used autofill. But if you're still actively browsing in Min, we could issue some fake requests to the CLI on an interval so you stay "active" longer (maybe up to a certain longer timeout, like a few hours). Not sure if that's a good idea or not - WDYT? If my password was 40 characters long, I wouldn't want to type it in very often either :) |
|
Hi, I found another problem related to this issue. I have 2FA enabled for 1Password so when I try to log in I end up in a loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
1password Password autofill should work as expected.
Actual Behavior
When selecting 1Password in the Preferences as my password manager, Min requests the email, password and secret key for the 1password account.
I type the information and press OK, but the window keeps coming back requesting to enter the information again and again.
I've already tested multiple times and the email, password and secret key are correct.
I've tried
sudo rm -rf /usr/local/bin/op && rm -rf ~/.opas well, but the issue persists.Any thoughts? Thanks!
The text was updated successfully, but these errors were encountered: