Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D radial trajectory bundle #113

Closed
wants to merge 9 commits into from

Conversation

Daval-G
Copy link
Collaborator

@Daval-G Daval-G commented May 23, 2024

This PR adds four 3D radial trajectories from the literature mentioned in issue #106:

  1. initialize_3D_phyllotaxis_radial from "Spiral Phyllotaxis: The Natural Way to Construct a 3D Radial Trajectory in MRI" Davide Piccini et al. (2011). Radial shots are oriented following a Fibonacci sphere lattice.
  2. initialize_3D_golden_means_radial from "Temporal Stability of Adaptive 3D Radial MRI Using Multidimensional Golden Means", Rachel W. Chan (2009). Radial shots are oriented following Fibonacci-based non-repeating angles.
  3. initialize_3D_wong_radial from "A Strategy for Sampling on a Sphere Applied to 3D Selective RF Pulse Design", Sam T. S. Wong and Mark S. Roos (1994). Radial shots are oriented following one or multiple spiral(s) over the k-space sphere.
  4. initialize_3D_park_radial from "A radial sampling strategy for uniform k-space coverage with retrospective respiratory gating in 3D ultrashort-echo-time lung imaging", Jinil Park et al. (2016). This pattern is based on Wong et al. (1994) from initialize_3D_wong_radial, enforcing a single spiral and ordering shots in a different way.

Documentation & examples coming soon.
The illustration below shows the tips of each radial shot for each of the four patterns.

Screenshot from 2024-05-23 14-38-43

@Daval-G Daval-G self-assigned this May 23, 2024
@Daval-G Daval-G requested a review from paquiteau May 23, 2024 11:32
@Daval-G
Copy link
Collaborator Author

Daval-G commented May 23, 2024

For some reason this PR got entangled with PR #105. It should be alright

@Daval-G Daval-G added the trajectories Issues concerning Non cartesian trajectories label May 23, 2024
@philouc
Copy link
Collaborator

philouc commented May 23, 2024

Thanks @Daval-G for this awesome work. I question came to my MIND. Should we use this new 3D radial traj available in MRI-NUFFT as initialization for 3D SPARKLING in the future? Do you expect any improvement notably for fMRI?

@paquiteau
Copy link
Member

paquiteau commented May 23, 2024

Awesome work once again!

Could you resubmit with only c98d54a ? I think that the only
one you want in the branch.

@paquiteau paquiteau added this to the v0.9.0 milestone May 23, 2024
@chaithyagr
Copy link
Member

I have also come across AZETK: https://pubmed.ncbi.nlm.nih.gov/32936490/
The advantage of this is that we can group a bunch of shots present spatially close in time and expect nearly good "uniform coverage still", sorta similar to 3) and 4).
@philouc when it comes to shot order atleast, I feel these methods are way better than what we used to do. I plan to take these methods in as good SPARKLING initalizers eventually

@chaithyagr
Copy link
Member

Coming to the examples, maybe we come up with "Trajectories" gallery which is more automatized? This could be a subject of another PR , which brings get_trajectory in place. WDYT @paquiteau

@philouc
Copy link
Collaborator

philouc commented May 23, 2024

Thanks @chaithyagr ; SHould we put that in the Maxime's plate for fMRI?

@chaithyagr
Copy link
Member

I think with the help of SHFJ (its a work from their team) we could see if we can get their implementations up. This could be a good oppurtunity for them to showcase their work and also foster better collaboration!

@Daval-G
Copy link
Collaborator Author

Daval-G commented May 24, 2024

This PR can be closed, as a cleaner version is available in PR #115.

@Daval-G Daval-G closed this May 24, 2024
@Daval-G Daval-G removed this from the v0.9.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trajectories Issues concerning Non cartesian trajectories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants