Changed return type of multithread_exec to iterator

[mtvch]

multithread_exec function returned result of different types depending on number of threads: if it's lesser than 2 - Iterator, otherwise - list.

In every place this function is used, result is expected to be of type list and it fails if result is an Iterator.

With this change function would always return Iterator to let user decide which type to convert it to.

[codecov]

Codecov Report

Merging #1019 (d672d92) into main (26ed132) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
+ Coverage   94.87%   94.93%   +0.06%     
==========================================
  Files         135      135              
  Lines        5559     5590      +31     
==========================================
+ Hits         5274     5307      +33     
+ Misses        285      283       -2     

Flag	Coverage Δ
unittests	94.93% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
doctr/datasets/loader.py	100.00% <100.00%> (ø)
doctr/models/preprocessor/pytorch.py	96.42% <100.00%> (ø)
doctr/models/preprocessor/tensorflow.py	96.15% <100.00%> (ø)
doctr/utils/multithreading.py	100.00% <100.00%> (ø)
doctr/models/zoo.py	100.00% <0.00%> (ø)
doctr/transforms/modules/base.py	94.59% <0.00%> (ø)
doctr/models/predictor/tensorflow.py	100.00% <0.00%> (ø)
...tr/models/classification/magc_resnet/tensorflow.py	100.00% <0.00%> (ø)
doctr/models/builder.py	99.03% <0.00%> (+0.01%)	⬆️
doctr/models/_utils.py	98.30% <0.00%> (+2.30%)	⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[felixdittrich92]

Hi @mtvch 👋,
thanks for the PR.

LGTM 👍
Only isort and mypy left to fix:
Inside the project you can run make quality to fix import sorting (isort) and get a output which changes you have to apply to make mypy happy :)

[frgfm]

Thanks for the PR!

I only have one comment about the potential latency change, let me know what you think :)

[frgfm]

LGTM +1 Only isort and mypy left to fix: Inside the project you can run make quality to fix import sorting (isort) and get a output which changes you have to apply to make mypy happy :)

Actually, make quality spots the error, and make style fixes black & isort :)

[felixdittrich92]

Hi @mtvch 👋 , any updates ? :)

[mtvch]

Hi @mtvch wave , any updates ? :)

Hi, @felixdittrich92!
Sorry, I'm busy right know and could not work on this... Also for me it takes more time, because I have little experience with Python.
But I'm planning to complete them until September (most likely next weekend)

[felixdittrich92]

Hi @mtvch wave , any updates ? :)

Hi, @felixdittrich92! Sorry, I'm busy right know and could not work on this... Also for me it takes more time, because I have little experience with Python. But I'm planning to complete them until September (most likely next weekend)

Thanks for the information. yes no stress 🤗

[felixdittrich92]

@mtvch only mypy fix left :)

doctr/models/preprocessor/tensorflow.py:120: error: Unused "type: ignore"
comment
                batches = self.batch_inputs(samples)  # type: ignore[arg-t...
                ^
doctr/models/preprocessor/tensorflow.py:[12](https://github.com/mindee/doctr/runs/8011083781?check_suite_focus=true#step:6:13)5: error: Unused "type: ignore"
comment
            batches = list(multithread_exec(self.normalize, batches))  # t...
            ^
doctr/models/preprocessor/pytorch.py:122: error: Unused "type: ignore" comment
                batches = self.batch_inputs(samples)  # type: ignore[arg-t...
                ^
doctr/models/preprocessor/pytorch.py:127: error: Unused "type: ignore" comment
            batches = list(multithread_exec(self.normalize, batches))  # t...
            ^
Found 4 errors in 2 files (checked [13](https://github.com/mindee/doctr/runs/8011083781?check_suite_focus=true#step:6:14)6 source files)

[mtvch]

@mtvch only mypy fix left :)

doctr/models/preprocessor/tensorflow.py:120: error: Unused "type: ignore"
comment
                batches = self.batch_inputs(samples)  # type: ignore[arg-t...
                ^
doctr/models/preprocessor/tensorflow.py:[12](https://github.com/mindee/doctr/runs/8011083781?check_suite_focus=true#step:6:13)5: error: Unused "type: ignore"
comment
            batches = list(multithread_exec(self.normalize, batches))  # t...
            ^
doctr/models/preprocessor/pytorch.py:122: error: Unused "type: ignore" comment
                batches = self.batch_inputs(samples)  # type: ignore[arg-t...
                ^
doctr/models/preprocessor/pytorch.py:127: error: Unused "type: ignore" comment
            batches = list(multithread_exec(self.normalize, batches))  # t...
            ^
Found 4 errors in 2 files (checked [13](https://github.com/mindee/doctr/runs/8011083781?check_suite_focus=true#step:6:14)6 source files)

Sorry...
Now it's fixed

[felixdittrich92]

Thanks a lot LGTM 👍