Migrate static data from github to monitoring middleware.

[marvinmindee]

Static data like models and images are now downloaded from a middleware and not from github releases, to enable more flexibility and monitor model downloads.

[frgfm]

Thanks @marvinmindee :)

Quick question though:

• I understand clearly the advantage of monitoring the downloads of models (perhaps there is a feature on Github to monitor asset download but I'm not sure)
• but for the rest (images, etc.), what would be the advantage?

Thanks 🙏

[marvinmindee]

Hello, we also added he images so that all static data are accessed the same way and we don't have things dowloaded from multiple places (especially when we'll want to add other static files, it's better if we don't have to think about whether it should be on github/release or doctr-static). It also leaves flexibility for later!

[felixdittrich92]

@frgfm @marvinmindee If we switch the models to doctr-static i agree that we should do this for all static data so we have all in one place 👍

one failing test left to fix :)

[codecov]

Codecov Report

Merging #1033 (5fe87d4) into main (61d0f1c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
- Coverage   94.93%   94.91%   -0.02%     
==========================================
  Files         135      135              
  Lines        5590     5590              
==========================================
- Hits         5307     5306       -1     
- Misses        283      284       +1     

Flag	Coverage Δ
unittests	94.91% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
doctr/datasets/cord.py	97.72% <ø> (ø)
doctr/datasets/funsd.py	97.43% <ø> (ø)
doctr/datasets/ic03.py	97.43% <ø> (ø)
doctr/datasets/ic13.py	96.77% <ø> (ø)
doctr/datasets/iiit5k.py	96.96% <ø> (ø)
doctr/datasets/imgur5k.py	93.33% <ø> (ø)
doctr/datasets/sroie.py	97.36% <ø> (ø)
doctr/datasets/svhn.py	95.34% <ø> (ø)
doctr/datasets/svt.py	97.29% <ø> (ø)
doctr/datasets/synthtext.py	94.73% <ø> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[charlesmindee]

Thanks, LGTM

[github-actions]

Hey @charlesmindee 👋
You merged this PR, but it is not correctly labeled. The list of valid labels is available at https://github.com/mindee/doctr/blob/main/.github/verify_pr_labels.py