Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datasets] Fix recognition parts of SynthText and IMGUR5K #1038

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • fixes the mem issue for SynthText and IMGUR5K Recognition
  • now we write a new dataset for both datasets to disk (fastest way)

related to:
#935 Fix for Recognition: SynthText and IMGUR5K (not beauty but it works well - no mem issue and whole speed up)

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1038 (3c1a7f7) into main (ea19161) will decrease coverage by 0.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   94.92%   94.91%   -0.02%     
==========================================
  Files         135      135              
  Lines        5599     5625      +26     
==========================================
+ Hits         5315     5339      +24     
- Misses        284      286       +2     
Flag Coverage Δ
unittests 94.91% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/imgur5k.py 92.53% <91.66%> (-0.80%) ⬇️
doctr/datasets/synthtext.py 95.08% <95.83%> (+0.34%) ⬆️
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: datasets Related to doctr.datasets labels Sep 1, 2022
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@felixdittrich92 felixdittrich92 merged commit 75aa42a into mindee:main Sep 1, 2022
@felixdittrich92 felixdittrich92 deleted the fix-reco-datasets branch September 1, 2022 14:41
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants