[Fix] unify recognition dataset parts return signature #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
felixdittrich92
added
type: enhancement
felixdittrich92
requested review from
aminemindee,
charlesmindee,
frgfm and
odulcy-mindee
Codecov Report
@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 94.93% 94.94%
=======================================
Files 135 135
Lines 5625 5633 +8
=======================================
+ Hits 5340 5348 +8
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
frgfm
reviewed
Sep 5, 2022
Comment on lines
+23
to
+31
|
|
||
| # Check target | ||
| if isinstance(target, dict): | ||
| assert "boxes" in target, "Target should contain 'boxes' key" | ||
| assert "labels" in target, "Target should contain 'labels' key" | ||
| else: | ||
| assert isinstance(target, str) or isinstance( | ||
| target, np.ndarray | ||
| ), "Target should be a string or a numpy array" |
There was a problem hiding this comment.
Considering that the target is unchanged since the constructor was run, that should be moved to the constructor (because otherwise it increases data reading latency)
There was a problem hiding this comment.
you mean to check it inside every dataset ? otherwise we have only access inside _read_sample and getitem !? And i don't think it changes the runtime noticeably
Comment on lines
+23
to
+32
|
|
||
| # Check target | ||
| if isinstance(target, dict): | ||
| assert "boxes" in target, "Target should contain 'boxes' key" | ||
| assert "labels" in target, "Target should contain 'labels' key" | ||
| else: | ||
| assert isinstance(target, str) or isinstance( | ||
| target, np.ndarray | ||
| ), "Target should be a string or a numpy array" | ||
|
|
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Hopefully that this is now a match to avoid mistakes for transformations
Closes:
#935