Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] revert dev deps mistake #1047

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[FIX] revert dev deps mistake #1047

merged 1 commit into from
Sep 6, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Sep 5, 2022 •
edited

This PR:

  • reverts a mistake which would install dev build deps from last pip and not from main (thanks @frgfm 馃槃)

see: #1031

@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build type: misc Miscellaneous labels Sep 5, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Sep 5, 2022
frgfm
frgfm approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix!

@felixdittrich92
Copy link
Contributor Author

Thanks Felix!

Thank you ! So we avoid a lot of confusion in the next release 馃槄

@felixdittrich92 felixdittrich92 merged commit 1cc073d into mindee:main Sep 6, 2022
@felixdittrich92 felixdittrich92 deleted the revert-dev-deps branch September 6, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frgfm frgfm frgfm approved these changes

@odulcy-mindee odulcy-mindee Awaiting requested review from odulcy-mindee

@aminemindee aminemindee Awaiting requested review from aminemindee

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

@marvinmindee marvinmindee Awaiting requested review from marvinmindee

Assignees
No one assigned
Labels
topic: build Related to dependencies and build type: misc Miscellaneous
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixdittrich92 @frgfm