-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README.md for custom fonts #1051
Updated README.md for custom fonts #1051
Conversation
As per discussion mindee#1046 a small description of how to train using custom fonts has been added to the README.md of references/recognition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @carl-krikorian 👋 thanks for the PR i have added 2 small points :)
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 135 135
Lines 5634 5634
=======================================
Hits 5349 5349
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Made a few changes to the documentation as per the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carl-krikorian thanks a lot :) 👍
Thank you for the opportunity! It's been a pleasure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I added a few comments
|
||
Running the training script should look like this for multiple custom fonts: | ||
```shell | ||
python references/recognition/train_pytorch.py crnn_vgg16_bn --epochs 5 --font "cusomt-font-1.ttf,custom-font-2.ttf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo here "custom-font-1.ttf" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Not very familiar with how I can fix this after the pull request was merged, do I need to create a new one? Or can I still push the changes from my branch? (I've tried this but doesn't seem to be an option).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @carl-krikorian short answer: new PR yep :)
As per discussion #1046 a small description of how to train using custom fonts has been added to the README.md of references/recognition.