Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md for custom fonts #1051

Merged

Conversation

carl-krikorian
Copy link
Contributor

As per discussion #1046 a small description of how to train using custom fonts has been added to the README.md of references/recognition.

As per discussion mindee#1046 a small description of how to train using custom fonts has been added to the README.md of references/recognition.
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carl-krikorian 👋 thanks for the PR i have added 2 small points :)

references/recognition/README.md Outdated Show resolved Hide resolved
references/recognition/README.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1051 (95dff3b) into main (1cc073d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files         135      135           
  Lines        5634     5634           
=======================================
  Hits         5349     5349           
  Misses        285      285           
Flag Coverage Δ
unittests 94.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: enhancement Improvement ext: references Related to references folder topic: text recognition Related to the task of text recognition labels Sep 8, 2022
@felixdittrich92 felixdittrich92 self-assigned this Sep 8, 2022
Made a few changes to the documentation as per the review.
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carl-krikorian thanks a lot :) 👍

@felixdittrich92 felixdittrich92 merged commit 93d823e into mindee:main Sep 8, 2022
@carl-krikorian
Copy link
Contributor Author

Thank you for the opportunity! It's been a pleasure.

Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a few comments

references/recognition/README.md Show resolved Hide resolved

Running the training script should look like this for multiple custom fonts:
```shell
python references/recognition/train_pytorch.py crnn_vgg16_bn --epochs 5 --font "cusomt-font-1.ttf,custom-font-2.ttf"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo here "custom-font-1.ttf" :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Not very familiar with how I can fix this after the pull request was merged, do I need to create a new one? Or can I still push the changes from my branch? (I've tried this but doesn't seem to be an option).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carl-krikorian short answer: new PR yep :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder topic: documentation Improvements or additions to documentation topic: text recognition Related to the task of text recognition type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants