Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply post release modifications v0.6.0 #1081

Merged
merged 1 commit into from
Sep 29, 2022
Merged

chore: apply post release modifications v0.6.0 #1081

merged 1 commit into from
Sep 29, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • add post release modifications
  • set dev to 0.7.0

@felixdittrich92 felixdittrich92 self-assigned this Sep 29, 2022
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build type: misc Miscellaneous labels Sep 29, 2022
@felixdittrich92 felixdittrich92 changed the title apply post release modifications chore: apply post release modifications v0.6.0 Sep 29, 2022
charlesmindee
charlesmindee approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@felixdittrich92 felixdittrich92 merged commit 1663333 into mindee:main Sep 29, 2022
@felixdittrich92 felixdittrich92 deleted the post-release branch September 29, 2022 12:35
frgfm
frgfm reviewed Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@frgfm frgfm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix! I think we shouldn't stress ourselves by setting a version index too far. If we release X.Y.0, the dev version should be something like X.Y.1a0 (otherwise if we release a patch, that will mess up some dev installations for a few people)

setup.py
VERSION = os.getenv("BUILD_VERSION", "0.6.0a0")
VERSION = os.getenv("BUILD_VERSION", "0.7.0a0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.6.1a0 out of safety ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i set it to 0.7.0 because we have no backlog. But you are right :)

@felixdittrich92 felixdittrich92 mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frgfm frgfm frgfm left review comments

@charlesmindee charlesmindee charlesmindee approved these changes

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
topic: build Related to dependencies and build type: misc Miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixdittrich92 @frgfm @charlesmindee @odulcy-mindee