Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py #1177

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Update utils.py #1177

merged 3 commits into from
Apr 18, 2023

Conversation

weiwangmeta
Copy link
Contributor

v3.0.0 rapidfuzz removed the rapidfuzz.string_metric.levenshtein API. The replacement is rapidfuzz.distance.Levenshtein.

v3.0.0 rapidfuzz removed the rapidfuzz.string_metric.levenshtein API. The replacement is rapidfuzz.distance.Levenshtein.
Use Levenshtein.distance API from rapidfuzz.distance to replace rapidfuzz.string_metric.levenshtein.
Update rapidfuzz dependency to be >=3.0.0 at which rapidfuzz.distance.Levenshtein.distance API was stablized.
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1177 (518714b) into main (3a270b0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         150      150           
  Lines        6418     6418           
=======================================
  Hits         6097     6097           
  Misses        321      321           
Flag Coverage Δ
unittests 94.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/utils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weiwangmeta 👍

@weiwangmeta
Copy link
Contributor Author

Please correct me if I'm wrong, but it looks like the two failing checks do not seem related to this PR.

@felixdittrich92
Copy link
Contributor

Please correct me if I'm wrong, but it looks like the two failing checks do not seem related to this PR.

Correct i will merge it in the next minutes :)

@felixdittrich92 felixdittrich92 self-assigned this Apr 18, 2023
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Apr 18, 2023
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build module: utils Related to doctr.utils type: misc Miscellaneous labels Apr 18, 2023
@felixdittrich92 felixdittrich92 merged commit 51c4237 into mindee:main Apr 18, 2023
56 of 58 checks passed
odulcy-mindee pushed a commit to odulcy-mindee/doctr that referenced this pull request Sep 1, 2023
odulcy-mindee pushed a commit that referenced this pull request Sep 1, 2023
odulcy-mindee pushed a commit that referenced this pull request Sep 1, 2023
odulcy-mindee pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: utils Related to doctr.utils topic: build Related to dependencies and build type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants