-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests/TF/build] enable missing classification onnx tests and set tensorflow lower bound to 2.11 #1182
[tests/TF/build] enable missing classification onnx tests and set tensorflow lower bound to 2.11 #1182
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1182 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 149 149
Lines 6417 6417
=======================================
Hits 6097 6097
Misses 320 320
Flags with carried forward coverage won't be shown. Click here to find out more. |
@frgfm Are you fine with increasing the minimum versions to fix this ? I think it would be also the time to drop py3.6 and 3.7 support and focus on 3.9 and 3.10 (especially CI) with >=3.8,<4 |
@felixdittrich92 Should it fix:
? |
@odulcy-mindee But this PR fixes the failing onnx exports for TF mobilenet. After this we have finally all models available for exporting into onnx format (up to the logits) The idea to drop py3.6 and py3.7 support is only to keep the repo + CI tests up to date |
@odulcy-mindee fine with the changes in this PR ? I opened #1183 for the grouped conv issue 👍🏼 |
Regarding the version specifiers, yes that's alright but for future debugging purposes, I suggest updating the PR description to specify which new features we want to get out of those recent releases (easier to track down problems in a specific version later on). About the python version, let me open a quick PR to check that (Python version upgrade can sometimes be tricky when the project on large platform-specific builds like DL frameworks) 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! Only a few suggestions for later debugging 👌
This PR:
Closes:
#978 and #790 🚀