-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] drop py3.6/3.7 support and update CI default to py3.8/3.9 #1184
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 95.01% 94.98% -0.03%
==========================================
Files 149 149
Lines 6417 6419 +2
==========================================
Hits 6097 6097
- Misses 320 322 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
@charlesmindee If we want to merge it you should disable the required checks in the GitHub actions merge it and enable the same updated checks again as required (you are the only one with repo Admin rights) :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was about to open a PR haha
I added a few comments but here are my high-level thoughts:
- dropping support of 3.6 & 3.7, and adding 3.9 & 3.10 is something
- moving the main version support from 3.8 to 3.10 is another
- I'd suggest staying on 3.8 which is still the most used python version (at least a few months back)
Best !
@frgfm i personally prefer especially for tests to have 2er steps (3.8 | 3.10 | 3.12 ..) but i am also fine to test it always on the most used python version :) But all tests was also running with python 3.10 so good to know :) Now it is up to @charlesmindee :) |
thanks, LGTM. Once @odulcy-mindee has approved we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixdittrich92 !!
This PR:
Any feedback is welcome :)