Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] drop py3.6/3.7 support and update CI default to py3.8/3.9 #1184

Merged
merged 9 commits into from
May 23, 2023

Conversation

felixT2K
Copy link
Contributor

@felixT2K felixT2K commented Apr 27, 2023

This PR:

  • drops support for python 3.6 and 3.7 (latest packages mostly have a mimum python version from 3.8 for example pytorch 2.0)
  • update CI also to be up to date

Any feedback is welcome :)

@felixT2K felixT2K changed the title update to min py 3.8 and ci default 3.10 [build] drop py3.6/3.7 support and update CI default to py3.10 Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1184 (e374e8d) into main (495c84c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   95.01%   94.98%   -0.03%     
==========================================
  Files         149      149              
  Lines        6417     6419       +2     
==========================================
  Hits         6097     6097              
- Misses        320      322       +2     
Flag Coverage Δ
unittests 94.98% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Apr 27, 2023
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build topic: ci Related to CI type: misc Miscellaneous labels Apr 27, 2023
@felixdittrich92
Copy link
Contributor

@charlesmindee If we want to merge it you should disable the required checks in the GitHub actions merge it and enable the same updated checks again as required (you are the only one with repo Admin rights) :)

@felixT2K felixT2K marked this pull request as ready for review April 27, 2023 11:19
Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was about to open a PR haha
I added a few comments but here are my high-level thoughts:

  • dropping support of 3.6 & 3.7, and adding 3.9 & 3.10 is something
  • moving the main version support from 3.8 to 3.10 is another
  • I'd suggest staying on 3.8 which is still the most used python version (at least a few months back)

Best !

.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/demo.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@felixT2K felixT2K requested a review from frgfm April 29, 2023 13:22
@felixT2K
Copy link
Contributor Author

@frgfm i personally prefer especially for tests to have 2er steps (3.8 | 3.10 | 3.12 ..) but i am also fine to test it always on the most used python version :)

But all tests was also running with python 3.10 so good to know :)

Now it is up to @charlesmindee :)

@felixT2K felixT2K changed the title [build] drop py3.6/3.7 support and update CI default to py3.10 [build] drop py3.6/3.7 support and update CI default to py3.8/3.9 Apr 29, 2023
@charlesmindee
Copy link
Collaborator

thanks, LGTM. Once @odulcy-mindee has approved we can merge

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixdittrich92 !!

@charlesmindee charlesmindee merged commit 1bf12a3 into mindee:main May 23, 2023
56 of 58 checks passed
@felixT2K felixT2K deleted the ci-updates branch July 3, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to dependencies and build topic: ci Related to CI type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants