-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Predictor precision PT backend #1204
[Feat] Predictor precision PT backend #1204
Conversation
e5073af
to
36a118e
Compare
@odulcy-mindee ready for review if tests done :) |
Codecov Report
@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
- Coverage 93.68% 93.67% -0.01%
==========================================
Files 154 154
Lines 6903 6911 +8
==========================================
+ Hits 6467 6474 +7
- Misses 436 437 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey @nikokks this is not related to the PR so please keep it clean ^^ Feel free to contact me on Linkedin about universial issues About the problem: It seems to be a issue with your Tensorflow Installation -> DNN lib cannot be found :) |
36a118e
to
81e2215
Compare
Now without the extra kwarg which would only effect PyTorch:
or
In tensorflow you can do:
We cannot automate this because all these settings are global in TF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely better, thanks Felix !
This PR:
Any feedback is welcome 馃
Revert for TF which would need to convert the weights while loading (takes a lot of time)
tests depends on: #1201
issue: #1112