Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] update test cases #1233

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Conversation

felixT2K
Copy link
Contributor

@felixT2K felixT2K commented Jun 28, 2023

This PR:

  • updates some parameterized test cases
  • change model for train_classification test (to discuss)

normally it should be fine to fix the job with using another model, because with mobilenet in TF it fails only if you try to train on CPU (train GPU + inference CPU and GPU works fine)
I would keep it on mind in: #1183 (checking after each TF release)

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1233 (9ddef0f) into main (b6db82f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files         154      154           
  Lines        6876     6876           
=======================================
  Hits         6578     6578           
  Misses        298      298           
Flag Coverage Δ
unittests 95.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@felixdittrich92 felixdittrich92 marked this pull request as ready for review June 28, 2023 12:45
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Jun 28, 2023
@felixdittrich92 felixdittrich92 added topic: ci Related to CI ext: tests Related to tests folder type: misc Miscellaneous labels Jun 28, 2023
@felixdittrich92 felixdittrich92 merged commit 32430fb into mindee:main Jul 3, 2023
58 checks passed
@felixT2K felixT2K deleted the update-test-cases branch July 3, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder topic: ci Related to CI type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants