Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: Replace tensorflow_addons #1252

Merged
merged 8 commits into from
Jul 20, 2023
Merged

[chore]: Replace tensorflow_addons #1252

merged 8 commits into from
Jul 20, 2023

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jul 17, 2023 •
edited

This PR:

Any feedback is welcome :)

@felixdittrich92 felixdittrich92 self-assigned this Jul 17, 2023
@felixdittrich92 felixdittrich92 added module: transforms Related to doctr.transforms framework: tensorflow Related to TensorFlow backend topic: build Related to dependencies and build type: misc Miscellaneous labels Jul 17, 2023
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited

Codecov Report

Merging #1252 (732766c) into main (4e1985f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files         154      154              
  Lines        6873     6903      +30     
==========================================
+ Hits         6574     6604      +30     
  Misses        299      299
Flag Coverage Δ
unittests 95.66% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/classification/vit/tensorflow.py 100.00% <ø> (ø)
doctr/models/recognition/master/tensorflow.py 98.21% <ø> (ø)
doctr/transforms/functional/tensorflow.py 100.00% <100.00%> (ø)
doctr/transforms/modules/tensorflow.py 83.33% <100.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes

@felixdittrich92 felixdittrich92 marked this pull request as ready for review July 17, 2023 14:03
@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee wdyt ? :)

@felixdittrich92 felixdittrich92 merged commit 1ad033e into mindee:main Jul 20, 2023
57 of 58 checks passed
@felixdittrich92 felixdittrich92 deleted the tensorflow-addons-replacement branch July 20, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixT2K felixT2K felixT2K left review comments

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

@frgfm frgfm Awaiting requested review from frgfm

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

Assignees

@felixdittrich92 felixdittrich92

Labels
framework: tensorflow Related to TensorFlow backend module: transforms Related to doctr.transforms topic: build Related to dependencies and build type: misc Miscellaneous
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixdittrich92 @odulcy-mindee @felixT2K