Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 fix bug when training object detection #1254

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

aminemindee
Copy link
Contributor

  • Small quick fix to make training object detection working again.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1254 (8d42ae2) into main (021d4f5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   95.63%   95.66%   +0.02%     
==========================================
  Files         154      154              
  Lines        6873     6873              
==========================================
+ Hits         6573     6575       +2     
+ Misses        300      298       -2     
Flag Coverage Δ
unittests 95.66% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/datasets/base.py 91.22% <100.00%> (ø)

... and 1 file with indirect coverage changes

@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: datasets Related to doctr.datasets topic: object detection Related to the task of object detection labels Jul 19, 2023
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Jul 19, 2023
@felixdittrich92
Copy link
Contributor

Thanks for the PR @aminemindee :)
Can we maybe add a short comment above the condition that it's only the case for a detection KIE dataset ?

BTW: file_utils.py seems not the right place for copy_tensor can we move it to https://github.com/mindee/doctr/tree/main/doctr/models/utils and add a short test ? (Because it's small but uncovered currently)

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @felixdittrich92 said, just add a comment and we can merge.

We'll move copy_tensor function in another PR

@aminemindee aminemindee merged commit 408854a into main Jul 20, 2023
58 checks passed
@felixdittrich92 felixdittrich92 deleted the fix-obj-detection-dataset branch September 8, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets topic: object detection Related to the task of object detection type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants