Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update to new torchvision API in models as well #1291

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

felixT2K
Copy link
Contributor

@felixT2K felixT2K commented Aug 28, 2023

This PR:

  • same as done for object detection update to new torchvision API

@felixdittrich92 felixdittrich92 self-assigned this Aug 28, 2023
@felixdittrich92 felixdittrich92 added this to the 0.7.0 milestone Aug 28, 2023
@felixdittrich92 felixdittrich92 added module: models Related to doctr.models framework: pytorch Related to PyTorch backend type: misc Miscellaneous labels Aug 28, 2023
@felixT2K felixT2K changed the title [chore] update to new torchvision API as well [chore] update to new torchvision API in models as well Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1291 (a7e324e) into main (3deac68) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         154      154              
  Lines        6903     6902       -1     
==========================================
- Hits         6612     6611       -1     
  Misses        291      291              
Flag Coverage Δ
unittests 95.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
doctr/models/classification/mobilenet/pytorch.py 100.00% <100.00%> (ø)
doctr/models/classification/resnet/pytorch.py 100.00% <100.00%> (ø)
doctr/models/classification/vgg/pytorch.py 100.00% <100.00%> (ø)
...s/detection/differentiable_binarization/pytorch.py 97.77% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

@felixdittrich92 felixdittrich92 merged commit 1f0169b into mindee:main Aug 28, 2023
57 of 58 checks passed
@felixT2K felixT2K deleted the fix-torchvision-warnings branch August 28, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants