Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Prob comp in vitstr and parseq for empty words #1345

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

felixT2K
Copy link
Contributor

This PR:

  • Add 0.0 in prob comp if word is empty

@felixdittrich92 felixdittrich92 added this to the 0.7.1 milestone Oct 12, 2023
@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: models Related to doctr.models framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text recognition Related to the task of text recognition labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1345 (b7bc285) into main (50d65d7) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1345   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         154      154           
  Lines        6902     6906    +4     
=======================================
+ Hits         6611     6615    +4     
  Misses        291      291           
Flag Coverage Δ
unittests 95.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/detection/differentiable_binarization/pytorch.py 97.77% <100.00%> (ø)
doctr/models/detection/linknet/pytorch.py 98.19% <100.00%> (ø)
doctr/models/recognition/master/pytorch.py 95.53% <100.00%> (+0.04%) ⬆️
doctr/models/recognition/parseq/pytorch.py 97.18% <100.00%> (+0.01%) ⬆️
doctr/models/recognition/parseq/tensorflow.py 97.33% <100.00%> (ø)
doctr/models/recognition/sar/pytorch.py 97.29% <100.00%> (ø)
doctr/models/recognition/vitstr/pytorch.py 100.00% <100.00%> (ø)
doctr/models/recognition/vitstr/tensorflow.py 97.61% <100.00%> (ø)
doctr/models/utils/pytorch.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@felixdittrich92 felixdittrich92 merged commit 7374e89 into mindee:main Oct 12, 2023
69 of 70 checks passed
@felixT2K felixT2K deleted the fix-prob-empty-words branch October 12, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: text recognition Related to the task of text recognition type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants