Added early stopping feature

[SkaarFacee]

Added feature request #924

[felixdittrich92]

Hey @SkaarFacee 👋

Thanks for working on this :)

The early stopping looks fine on a first view 👍
But could you please revert all the other changes which are not related to your early stopping addition ?

See the div: https://github.com/mindee/doctr/pull/1397/files

[odulcy-mindee]

Hello @SkaarFacee 👋,

Thank you very much for this contribution !
I also added some comments

[odulcy-mindee]

But could you please revert all the other changes which are not related to your early stopping addition ?

@SkaarFacee You just need to rebase your PR on main

[felixdittrich92]

@SkaarFacee @odulcy-mindee For the scope of this PR i think cleaning up the mentioned points is enough wdyt ?
@odulcy-mindee We can discuss afterwards if we want to move it into doctr in another PR are you fine with it ? :)

[odulcy-mindee]

We can discuss afterwards if we want to move it into doctr in another PR are you fine with it ? :)

@felixdittrich92 Yes, sure !

[SkaarFacee]

But could you please revert all the other changes which are not related to your early stopping addition ?

@SkaarFacee You just need to rebase your PR on main

Won't that revert the changes that I made as well ?

[felixdittrich92]

But could you please revert all the other changes which are not related to your early stopping addition ?

@SkaarFacee You just need to rebase your PR on main

Won't that revert the changes that I made as well ?

No rebase keeps your changes but you need to pull the main branch latest changes before

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f36c7c9) 95.79% compared to head (22e323c) 95.76%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   95.79%   95.76%   -0.03%     
==========================================
  Files         155      155              
  Lines        6942     6942              
==========================================
- Hits         6650     6648       -2     
- Misses        292      294       +2     

Flag	Coverage Δ
unittests	95.76% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SkaarFacee]

But could you please revert all the other changes which are not related to your early stopping addition ?

@SkaarFacee You just need to rebase your PR on main

Won't that revert the changes that I made as well ?

No rebase keeps your changes but you need to pull the main branch latest changes before

Can you make sure everything is alright now ?

[felixdittrich92]

Thanks looks mostly fine now :) I have added a few minor things which should be changed in all files :)

[felixT2K]

Thanks @SkaarFacee Looks good now 👍🏼

[odulcy-mindee]

Thanks @SkaarFacee ! 👍

[SkaarFacee]

Thanks @SkaarFacee ! 👍

Aww thanks. It was really fun. I hope to contribute more :)