Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds conda recipe & corresponding CI jobs #1414

Merged
merged 17 commits into from
Feb 6, 2024
Merged

feat: Adds conda recipe & corresponding CI jobs #1414

merged 17 commits into from
Feb 6, 2024

Conversation

frgfm
Copy link
Collaborator

@frgfm frgfm commented Dec 22, 2023

This PR introduces the following modifications:

  • adds a conda recipe
  • adds a CI job to build & upload to anaconda cloud upon release
  • adds another to check that it can then be installed

Note: for now the recipe is without TF or PyTorch. Conditional builds seem tricky for now 😅

cc @mara004

Closes #113

@frgfm frgfm added topic: build Related to dependencies and build type: new feature New feature labels Dec 22, 2023
@frgfm frgfm added this to the 0.8.0 milestone Dec 22, 2023
@frgfm frgfm self-assigned this Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed927bd) 95.79% compared to head (ee0c273) 95.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   95.79%   95.78%   -0.02%     
==========================================
  Files         155      155              
  Lines        6950     6950              
==========================================
- Hits         6658     6657       -1     
- Misses        292      293       +1     
Flag Coverage Δ
unittests 95.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.conda/meta.yaml Outdated Show resolved Hide resolved
@felixdittrich92
Copy link
Contributor

Overall fine but i would suggest to update the docs accordingly :)

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 👍
Last two comments from my side ^^

.conda/meta.yaml Show resolved Hide resolved
.github/workflows/builds.yml Show resolved Hide resolved
VERSION: ${{ steps.release_tag.outputs.VERSION }}
run: |
echo "BUILD_VERSION=${VERSION}" >> $GITHUB_ENV
python setup.py sdist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling setup.py directly is deprecated, you'll want something like python -m build --sdist instead
see also https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frgfm ? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know, thanks mara!
But for this PR, I don't think we need the edit:

  • we'd have to do this for the other occurrences in the repo (feels like a standalone PR to me, and we should check backward compatibility)
  • it will be deprecated but it's still working to the best of my understanding right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be deprecated but it's still working to the best of my understanding right?

Yes, for the time being. They might want to remove it after some deprecation period, but I don't know if they'll ever do, as this somehow doesn't seem to have reached the crowd at large.

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm 🤗

@felixdittrich92
Copy link
Contributor

@odulcy-mindee How does it look do we have a token now ? 😅

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token has been added !

@felixdittrich92 felixdittrich92 merged commit 13dd377 into main Feb 6, 2024
66 of 68 checks passed
@felixdittrich92 felixdittrich92 deleted the conda branch February 6, 2024 15:23
@mara004
Copy link
Contributor

mara004 commented Feb 6, 2024

I suppose you're aware the installation instructions are yet TBD

@felixdittrich92
Copy link
Contributor

@mara004 yep after the next release if it's available :)

For the moment CI conda build job fails this needs to be fixed first ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to dependencies and build type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[conda] Unable to make a conda build
4 participants