Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT] remove submodule from textnet arch #1436

Merged
merged 4 commits into from
Jan 26, 2024
Merged

[PT] remove submodule from textnet arch #1436

merged 4 commits into from
Jan 26, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jan 23, 2024 •
edited

This PR:

  • remove useless submodule to make it easier to extract the required midlevel features
  • lower some probs in det augmentations

@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee Could you please upload the checkpoints ?

@felixdittrich92 felixdittrich92 added this to the 0.8.0 milestone Jan 23, 2024
@felixdittrich92 felixdittrich92 self-assigned this Jan 23, 2024
@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: models Related to doctr.models framework: pytorch Related to PyTorch backend topic: character classification Related to the task of character classification labels Jan 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a010972) 95.82% compared to head (8649f63) 95.85%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
+ Coverage   95.82%   95.85%   +0.03%     
==========================================
  Files         161      162       +1     
  Lines        7085     7095      +10     
==========================================
+ Hits         6789     6801      +12     
+ Misses        296      294       -2
Flag Coverage Δ
unittests 95.85% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 mentioned this pull request Jan 26, 2024
Merged
@felixdittrich92 felixdittrich92 merged commit abf0571 into mindee:main Jan 26, 2024
69 checks passed
@felixdittrich92 felixdittrich92 deleted the textnet-update branch January 26, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: character classification Related to the task of character classification type: enhancement Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixdittrich92 @odulcy-mindee