Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix streamlit demo #1447

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[FIX] Fix streamlit demo #1447

merged 2 commits into from
Feb 2, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • fix for demo with latest streamlit version

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5445ef) 95.81% compared to head (8bb3bb5) 95.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         162      162           
  Lines        7101     7101           
=======================================
  Hits         6804     6804           
  Misses        297      297           
Flag Coverage Δ
unittests 95.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

odulcy-mindee
odulcy-mindee previously approved these changes Feb 1, 2024
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

FYI, I set st.json(..., expanded=False) on HF Space, otherwise when you enlarge one of the images above with JSON expanded, you got a blank page and you need to scroll to see your image. This way, it does not look like a bug "from our side" but a "bug" on Steamlit

@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee sounds good i have applied it also to the local demo

@felixdittrich92 felixdittrich92 merged commit 92a0b25 into mindee:main Feb 2, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder type: bug Something isn't working
Projects
None yet
2 participants