Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ PT db_resnet50 checkpoint #1465

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

odulcy-mindee
Copy link
Collaborator

No description provided.

@felixdittrich92 felixdittrich92 added this to the 0.8.0 milestone Feb 13, 2024
@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: models Related to doctr.models framework: pytorch Related to PyTorch backend topic: text detection Related to the task of text detection labels Feb 13, 2024
@felixdittrich92
Copy link
Contributor

@odulcy-mindee ignore this failing stupid test 😅 (only the index has changed)
I will open a PR afterwards with a fix - because i have also to pin tf to <2.16 so we can combine this in one PR

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Feb 13, 2024

@odulcy-mindee

assert out.pages[0].predictions[CLASS_NAME][6].value == "revised"

assert out.pages[0].predictions[CLASS_NAME][4].value == "revised"
geometry_revised = np.array([[0.7548828125, 0.126953125], [0.8388671875, 0.1484375]])
assert np.allclose(np.array(out.pages[0].predictions[CLASS_NAME][4].geometry), geometry_revised, rtol=0.05)

Only index changed from 6 to 4 in both lines

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty 👍

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3811400) 95.82% compared to head (cb0eff1) 95.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   95.82%   95.83%   +0.01%     
==========================================
  Files         162      162              
  Lines        7112     7112              
==========================================
+ Hits         6815     6816       +1     
+ Misses        297      296       -1     
Flag Coverage Δ
unittests 95.83% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odulcy-mindee odulcy-mindee merged commit 4ff5ce2 into mindee:main Feb 13, 2024
70 checks passed
@odulcy-mindee odulcy-mindee deleted the pt_db_resnet50_checkpoint branch February 13, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants