Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve loading time when test only #294

Merged
merged 1 commit into from
Jun 3, 2021
Merged

feat: improve loading time when test only #294

merged 1 commit into from
Jun 3, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR moves the train set loader after the test-only check to avoid a 1-min wait when there is no need to load the full train set.

Any feedback is welcome!

@charlesmindee charlesmindee added the ext: references Related to references folder label Jun 3, 2021
@charlesmindee charlesmindee added this to the 0.3.0 milestone Jun 3, 2021
@charlesmindee charlesmindee self-assigned this Jun 3, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee added the type: enhancement Improvement label Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #294 (97b6ff9) into main (6933091) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   96.07%   96.12%   +0.04%     
==========================================
  Files          48       48              
  Lines        2089     2089              
==========================================
+ Hits         2007     2008       +1     
+ Misses         82       81       -1     
Flag Coverage Δ
unittests 96.12% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tr/models/detection/differentiable_binarization.py 93.65% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6933091...97b6ff9. Read the comment docs.

@charlesmindee charlesmindee merged commit 301be21 into main Jun 3, 2021
@charlesmindee charlesmindee deleted the script branch June 3, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants