Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added PyTorch support of VGG backbones #328

Merged
merged 2 commits into from
Jun 23, 2021
Merged

feat: Added PyTorch support of VGG backbones #328

merged 2 commits into from
Jun 23, 2021

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Jun 23, 2021

Following up on #261, this PR introduces the following modifications:

  • added pytorch version of vgg16_bn
  • updated unittests

Any feedback is welcome!

@fg-mindee fg-mindee added module: models Related to doctr.models ext: tests Related to tests folder framework: pytorch Related to PyTorch backend labels Jun 23, 2021
@fg-mindee fg-mindee added this to the 0.3.0 milestone Jun 23, 2021
@fg-mindee fg-mindee self-assigned this Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #328 (1ccc0cb) into main (018d44a) will decrease coverage by 3.14%.
The diff coverage is 93.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   97.61%   94.47%   -3.15%     
==========================================
  Files          32       74      +42     
  Lines        1007     2913    +1906     
==========================================
+ Hits          983     2752    +1769     
- Misses         24      161     +137     
Flag Coverage Δ
unittests 94.47% <93.47%> (-3.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/master.py 69.56% <69.56%> (ø)
doctr/file_utils.py 74.46% <74.46%> (ø)
doctr/models/recognition/transformer.py 87.09% <87.09%> (ø)
doctr/models/detection/linknet/base.py 87.67% <87.67%> (ø)
doctr/models/data_utils.py 88.67% <88.67%> (ø)
doctr/datasets/recognition.py 89.47% <89.47%> (ø)
doctr/transforms/modules/base.py 89.65% <89.65%> (ø)
doctr/utils/visualization.py 93.02% <91.30%> (-6.98%) ⬇️
doctr/datasets/ocr.py 91.66% <91.66%> (ø)
...dels/detection/differentiable_binarization/base.py 91.71% <91.71%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cfd61a...1ccc0cb. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit a941509 into main Jun 23, 2021
@fg-mindee fg-mindee deleted the vgg branch June 23, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder framework: pytorch Related to PyTorch backend module: models Related to doctr.models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants