Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added schedulers to Pytorch training scripts #381

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

fg-mindee
Copy link
Contributor

Following up on #347, this PR adds LR scheduler to the PyTorch training scripts.

Closes #347

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement ext: references Related to references folder framework: pytorch Related to PyTorch backend labels Jul 13, 2021
@fg-mindee fg-mindee added this to the 0.3.1 milestone Jul 13, 2021
@fg-mindee fg-mindee self-assigned this Jul 13, 2021
charlesmindee
charlesmindee previously approved these changes Jul 13, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #381 (0143ad1) into main (58a3f8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          83       83           
  Lines        3554     3554           
=======================================
  Hits         3420     3420           
  Misses        134      134           
Flag Coverage Δ
unittests 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a3f8d...0143ad1. Read the comment docs.

@charlesmindee charlesmindee merged commit 330d52f into main Jul 13, 2021
@charlesmindee charlesmindee deleted the torch-scheduler branch July 13, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[references] Add learning rate scheduler
2 participants